From 8356cfc23de28ad91b1c8ff3a24cfaec9f2f91e2 Mon Sep 17 00:00:00 2001 From: Tomas Kracmar Date: Fri, 6 Nov 2026 08:08:06 +0100 Subject: [PATCH] fix(preflight): accept tokenGroups as SecurityIdentifier objects The replication-rights pre-check cast every tokenGroups entry to byte[], which fails when the ActiveDirectory module already returns SecurityIdentifier objects ("Cannot convert S-1-5-32-545 ... to System.Byte[]"), so the check was skipped with a warning. Handle both forms. --- src/Elysium/Private/AdPreflight.ps1 | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/Elysium/Private/AdPreflight.ps1 b/src/Elysium/Private/AdPreflight.ps1 index 36595a3..d45fb7d 100644 --- a/src/Elysium/Private/AdPreflight.ps1 +++ b/src/Elysium/Private/AdPreflight.ps1 @@ -82,9 +82,13 @@ function Test-ReplicationPermissions { # Look up by DistinguishedName (unambiguous) rather than re-deriving the username format. $adUserWithTokenGroups = Get-ADUser -Identity $adUser.DistinguishedName -Server $Server -Credential $Credential ` -Properties tokenGroups -ErrorAction Stop - foreach ($sidBytes in $adUserWithTokenGroups.tokenGroups) { - $sid = New-Object System.Security.Principal.SecurityIdentifier(@([byte[]]$sidBytes), 0) - [void]$callerSids.Add($sid.Value) + # The ActiveDirectory module returns these as SecurityIdentifier objects (raw byte arrays on some builds). + foreach ($tokenGroup in $adUserWithTokenGroups.tokenGroups) { + if ($tokenGroup -is [System.Security.Principal.SecurityIdentifier]) { + [void]$callerSids.Add($tokenGroup.Value) + } else { + [void]$callerSids.Add((New-Object System.Security.Principal.SecurityIdentifier(@([byte[]]$tokenGroup), 0)).Value) + } } # adminCount=1 means SDProp is managing this account; it runs every 60 min and can