The three import loops iterated `$set.ToArray() | Sort-Object` over HashSet[string] collections. HashSet<T> has no ToArray instance method - that is a LINQ extension method, which PowerShell does not bind - so member-access enumeration applied .ToArray() to each string in the set and threw "[System.String] does not contain a method named 'ToArray'". An empty set enumerates nothing and passes silently, but the hash list is never empty (configured sources, or the default KHDB, otherwise the script throws earlier). So every run opened the store, crashed on the first import, and closed it again with nothing imported. Same behavior on Windows PowerShell 5.1 and PowerShell 7. Pipe the sets into Sort-Object directly, which enumerates them. Found by the Pester test written for the upcoming module conversion. Reproduced and verified end-to-end with a stub LithnetPasswordProtection module on PSModulePath: before, Open-Store -> ToArray error -> Close-Store; after, the KHDB, plaintext and banned-word lists are each imported and the store is closed.
170 lines
7.3 KiB
PowerShell
170 lines
7.3 KiB
PowerShell
##################################################
|
|
## ____ ___ ____ _____ _ _ _____ _____ ##
|
|
## / ___/ _ \| _ \| ____| | \ | | ____|_ _| ##
|
|
## | | | | | | |_) | _| | \| | _| | | ##
|
|
## | |__| |_| | _ <| |___ _| |\ | |___ | | ##
|
|
## \____\__\_\_| \_\_____(_)_| \_|_____| |_| ##
|
|
##################################################
|
|
## Project: Elysium ##
|
|
## File: Update-LithnetStore.ps1 ##
|
|
## Support: support@cqre.net ##
|
|
##################################################
|
|
|
|
<#
|
|
.SYNOPSIS
|
|
Populates a Lithnet Password Protection store with compromised passwords and banned words.
|
|
|
|
.DESCRIPTION
|
|
Reads configuration from ElysiumSettings.txt (or a provided settings file), opens the Lithnet
|
|
Password Protection store, optionally synchronizes with Have I Been Pwned, imports local NTLM
|
|
hash lists, plaintext password lists, and banned-word files.
|
|
#>
|
|
|
|
[CmdletBinding()]
|
|
param(
|
|
[string]$SettingsPath,
|
|
[string[]]$HashFiles,
|
|
[string[]]$PlaintextFiles,
|
|
[string[]]$BannedWordFiles,
|
|
[switch]$SkipHibpSync
|
|
)
|
|
|
|
$ErrorActionPreference = 'Stop'
|
|
Set-StrictMode -Version Latest
|
|
[string]$commonHelper = Join-Path -Path $PSScriptRoot -ChildPath 'Elysium.Common.ps1'
|
|
if (-not (Test-Path -LiteralPath $commonHelper)) { throw "Common helper not found at $commonHelper" }
|
|
. $commonHelper
|
|
Restart-WithPwshIfAvailable -BoundParameters $PSBoundParameters -UnboundArguments $MyInvocation.UnboundArguments
|
|
|
|
function Start-LithnetTranscript {
|
|
param([string]$BasePath)
|
|
try {
|
|
$logsDir = Join-Path -Path $BasePath -ChildPath 'Reports/logs'
|
|
if (-not (Test-Path $logsDir)) { New-Item -Path $logsDir -ItemType Directory -Force | Out-Null }
|
|
$ts = Get-Date -Format 'yyyyMMdd-HHmmss'
|
|
$logPath = Join-Path -Path $logsDir -ChildPath "update-lithnet-$ts.log"
|
|
Start-Transcript -Path $logPath -Force | Out-Null
|
|
} catch {
|
|
Write-Warning "Could not start transcript: $($_.Exception.Message)"
|
|
}
|
|
}
|
|
|
|
function Stop-LithnetTranscript { try { Stop-Transcript | Out-Null } catch {} }
|
|
|
|
function Get-BooleanSetting {
|
|
param(
|
|
[string]$Value,
|
|
[bool]$Default = $false
|
|
)
|
|
if ([string]::IsNullOrWhiteSpace($Value)) { return $Default }
|
|
try { return [System.Convert]::ToBoolean($Value) } catch { return $Default }
|
|
}
|
|
|
|
function Get-ListFromSetting {
|
|
param([string]$Value)
|
|
if ([string]::IsNullOrWhiteSpace($Value)) { return @() }
|
|
return ($Value -split '[,;]' | ForEach-Object { $_.Trim() } | Where-Object { $_ })
|
|
}
|
|
|
|
function Resolve-ExistingPath {
|
|
param([string]$PathValue, [string]$Description)
|
|
if ([string]::IsNullOrWhiteSpace($PathValue)) { throw "$Description path was not provided." }
|
|
if (-not (Test-Path -LiteralPath $PathValue)) {
|
|
throw "$Description not found at '$PathValue'."
|
|
}
|
|
return (Resolve-Path -LiteralPath $PathValue).Path
|
|
}
|
|
|
|
Start-LithnetTranscript -BasePath $PSScriptRoot
|
|
try {
|
|
if (-not $SettingsPath) {
|
|
$SettingsPath = Join-Path -Path $PSScriptRoot -ChildPath 'ElysiumSettings.txt'
|
|
}
|
|
if (-not (Test-Path -LiteralPath $SettingsPath)) { throw "Settings file not found at $SettingsPath" }
|
|
$settings = Read-KeyValueSettingsFile -Path $SettingsPath
|
|
|
|
$storePathSetting = $settings['LithnetStorePath']
|
|
$storePath = Resolve-ExistingPath -PathValue $storePathSetting -Description 'Lithnet store'
|
|
|
|
$settingsHashSources = Get-ListFromSetting -Value $settings['LithnetHashSources']
|
|
$settingsPlainSources = Get-ListFromSetting -Value $settings['LithnetPlaintextSources']
|
|
$settingsBannedSources = Get-ListFromSetting -Value $settings['LithnetBannedWordSources']
|
|
|
|
$hashSourcePaths = New-Object System.Collections.Generic.HashSet[string] ([System.StringComparer]::OrdinalIgnoreCase)
|
|
foreach ($path in @($HashFiles) + $settingsHashSources) {
|
|
if ([string]::IsNullOrWhiteSpace($path)) { continue }
|
|
$resolved = Resolve-ExistingPath -PathValue $path -Description 'Hash list'
|
|
[void]$hashSourcePaths.Add($resolved)
|
|
}
|
|
if ($hashSourcePaths.Count -eq 0) {
|
|
# Same resolution as Update-KHDB.ps1 / Test-WeakADPasswords.ps1, so the default is the KHDB they use.
|
|
$installationPath = $settings['InstallationPath']
|
|
if ([string]::IsNullOrWhiteSpace($installationPath)) { $installationPath = $PSScriptRoot }
|
|
elseif (-not [System.IO.Path]::IsPathRooted($installationPath)) { $installationPath = Join-Path -Path $PSScriptRoot -ChildPath $installationPath }
|
|
$khdbName = if ([string]::IsNullOrWhiteSpace($settings['WeakPasswordsDatabase'])) { 'khdb.txt' } else { $settings['WeakPasswordsDatabase'] }
|
|
$defaultKhdb = Join-Path -Path $installationPath -ChildPath $khdbName
|
|
if (Test-Path -LiteralPath $defaultKhdb) {
|
|
[void]$hashSourcePaths.Add((Resolve-Path -LiteralPath $defaultKhdb).Path)
|
|
} else {
|
|
throw "No hash files were provided via parameters or LithnetHashSources, and the KHDB was not found at '$defaultKhdb'."
|
|
}
|
|
}
|
|
|
|
$plaintextSourcePaths = New-Object System.Collections.Generic.HashSet[string] ([System.StringComparer]::OrdinalIgnoreCase)
|
|
foreach ($path in @($PlaintextFiles) + $settingsPlainSources) {
|
|
if ([string]::IsNullOrWhiteSpace($path)) { continue }
|
|
$resolved = Resolve-ExistingPath -PathValue $path -Description 'Plaintext password list'
|
|
[void]$plaintextSourcePaths.Add($resolved)
|
|
}
|
|
|
|
$bannedWordSourcePaths = New-Object System.Collections.Generic.HashSet[string] ([System.StringComparer]::OrdinalIgnoreCase)
|
|
foreach ($path in @($BannedWordFiles) + $settingsBannedSources) {
|
|
if ([string]::IsNullOrWhiteSpace($path)) { continue }
|
|
$resolved = Resolve-ExistingPath -PathValue $path -Description 'Banned word list'
|
|
[void]$bannedWordSourcePaths.Add($resolved)
|
|
}
|
|
|
|
$syncHibp = Get-BooleanSetting -Value $settings['LithnetSyncHibp'] -Default:$false
|
|
if ($SkipHibpSync) { $syncHibp = $false }
|
|
|
|
Write-Host "Importing LithnetPasswordProtection module..."
|
|
try {
|
|
Import-Module -Name LithnetPasswordProtection -ErrorAction Stop | Out-Null
|
|
} catch {
|
|
throw "LithnetPasswordProtection module not found: $($_.Exception.Message). Install it from https://github.com/lithnet/password-protection."
|
|
}
|
|
|
|
Write-Host ("Opening Lithnet store at '{0}'..." -f $storePath)
|
|
Open-Store -Path $storePath
|
|
$storeOpened = $true
|
|
try {
|
|
if ($syncHibp) {
|
|
Write-Host 'Synchronizing compromised hashes from Have I Been Pwned (this can take a while)...'
|
|
Sync-HashesFromHibp
|
|
}
|
|
|
|
foreach ($hashFile in ($hashSourcePaths | Sort-Object)) {
|
|
Write-Host ("Importing NTLM hash list '{0}'..." -f $hashFile)
|
|
Import-CompromisedPasswordHashes -Filename $hashFile
|
|
}
|
|
|
|
foreach ($plainFile in ($plaintextSourcePaths | Sort-Object)) {
|
|
Write-Host ("Importing plaintext password list '{0}'..." -f $plainFile)
|
|
Import-CompromisedPasswords -Filename $plainFile
|
|
}
|
|
|
|
foreach ($bannedFile in ($bannedWordSourcePaths | Sort-Object)) {
|
|
Write-Host ("Importing banned word list '{0}'..." -f $bannedFile)
|
|
Import-BannedWords -Filename $bannedFile
|
|
}
|
|
|
|
Write-Host 'Lithnet store update completed successfully.'
|
|
} finally {
|
|
if ($storeOpened) {
|
|
try { Close-Store } catch {}
|
|
}
|
|
}
|
|
} finally {
|
|
Stop-LithnetTranscript
|
|
}
|