cqrenet/matrix-docker-ansible-deploy
6
0
Fork 0
mirror of https://github.com/spantaleev/matrix-docker-ansible-deploy.git synced 2026-09-17 21:30:09 +00:00
Code Issues Wiki Activity

Limit Molecule checks on new branches to changed roles

Browse Source
This commit is contained in:
Slavi Pantaleev
2026-09-16 19:16:36 +03:00
parent f8d86d1cca
commit 2ec431a68a
2 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/molecule.yml
+9 -4
View File
@@ -58,6 +58,7 @@ jobs:
EVENT_NAME: ${{ github.event_name }} EVENT_NAME: ${{ github.event_name }}
BASE_SHA: ${{ github.event.pull_request.base.sha }} BASE_SHA: ${{ github.event.pull_request.base.sha }}
BEFORE_SHA: ${{ github.event.before }} BEFORE_SHA: ${{ github.event.before }}
DEFAULT_BRANCH: ${{ github.event.repository.default_branch }}
INPUT_ROLE: ${{ inputs.role }} INPUT_ROLE: ${{ inputs.role }}
run: | run: |
set -euo pipefail set -euo pipefail
@@ -77,10 +78,12 @@ jobs:
exit 0 exit 0
fi fi
# A hand-triggered run with no role named, and any run where the diff # New branches have an all-zero before SHA. Compare them with their
# base is unusable (a new branch, a force push, the very first commit), # common ancestor with the default branch, so the first Renovate push
# falls back to every role that has a scenario. That is the safe # tests only the roles it changes. The same fallback handles a force
# direction to fail in: too much testing rather than too little. # push whose previous commit is no longer available locally.
# Manual runs without a role, and pushes with no usable comparison,
# still consider every scenario.
base="" base=""
case "${EVENT_NAME}" in case "${EVENT_NAME}" in
pull_request) base="${BASE_SHA}" ;; pull_request) base="${BASE_SHA}" ;;
@@ -88,6 +91,8 @@ jobs:
if [ -n "${BEFORE_SHA}" ] && [ "${BEFORE_SHA}" != "0000000000000000000000000000000000000000" ] \ if [ -n "${BEFORE_SHA}" ] && [ "${BEFORE_SHA}" != "0000000000000000000000000000000000000000" ] \
&& git cat-file -e "${BEFORE_SHA}^{commit}" 2>/dev/null; then && git cat-file -e "${BEFORE_SHA}^{commit}" 2>/dev/null; then
base="${BEFORE_SHA}" base="${BEFORE_SHA}"
elif [ -n "${DEFAULT_BRANCH}" ] && [ "${GITHUB_REF}" != "refs/heads/${DEFAULT_BRANCH}" ]; then
base="$(git merge-base HEAD "refs/remotes/origin/${DEFAULT_BRANCH}" || true)"
fi fi
;; ;;
esac esac
docs/molecule-testing.md
+1 -1
View File
@@ -28,7 +28,7 @@ Molecule is deliberately **not** part of the `prek` hooks. A run is far too slow
`.github/workflows/molecule.yml` does not run every scenario on every push — with one repository holding every role, that would be unaffordable. Its first job works out which roles the push actually touched, keeps the ones that have a scenario, and builds the job matrix from those. A documentation change runs nothing. `.github/workflows/molecule.yml` does not run every scenario on every push — with one repository holding every role, that would be unaffordable. Its first job works out which roles the push actually touched, keeps the ones that have a scenario, and builds the job matrix from those. A documentation change runs nothing.
When the diff base cannot be determined (a new branch, a force push), it falls back to running every scenario, which errs toward testing too much rather than too little. `workflow_dispatch` accepts an optional role name. For pushes, CI compares against the previous commit. On a new branch, or when the previous commit is unavailable after a force push, it instead compares against the branch's common ancestor with the default branch. This keeps a new Renovate branch limited to the roles it changes. If no usable comparison exists, it falls back to running every scenario. Changes to `molecule-shared/` or the Molecule workflow also run every scenario. `workflow_dispatch` accepts an optional role name; leaving it empty runs every scenario.
## Automerge ## Automerge