Use fully-qualified module names for builtin Ansible modules

Related to https://github.com/spantaleev/matrix-docker-ansible-deploy/pull/1939

roles/matrix-nginx-proxy/tasks/setup_nginx_proxy.yml

@@ -11,7 +11,7 @@
 # to be unnecessary.
 #
 - name: Ensure Matrix nginx-proxy paths exist
-  file:
+  ansible.builtin.file:
     path: "{{ item.path }}"
     state: directory
     mode: 0750
@@ -25,7 +25,7 @@
   when: item.when|bool
 
 - name: Ensure Matrix nginx-proxy configured (main config override)
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/nginx/nginx.conf.j2"
     dest: "{{ matrix_nginx_proxy_base_path }}/nginx.conf"
     mode: 0644
@@ -36,123 +36,123 @@
   when: matrix_nginx_proxy_proxy_matrix_metrics_enabled|bool and matrix_nginx_proxy_proxy_matrix_metrics_basic_auth_enabled|bool
 
 - name: Ensure Matrix nginx-proxy configured (generic)
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/nginx/conf.d/nginx-http.conf.j2"
     dest: "{{ matrix_nginx_proxy_confd_path }}/nginx-http.conf"
     mode: 0644
   when: matrix_nginx_proxy_enabled|bool
 
 - name: Ensure Matrix nginx-proxy configuration for matrix-synapse exists
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/nginx/conf.d/matrix-synapse.conf.j2"
     dest: "{{ matrix_nginx_proxy_confd_path }}/matrix-synapse.conf"
     mode: 0644
   when: matrix_nginx_proxy_proxy_synapse_enabled|bool
 
 - name: Ensure Matrix nginx-proxy configuration for matrix-synapse deleted
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_nginx_proxy_confd_path }}/matrix-synapse.conf"
     state: absent
   when: "not matrix_nginx_proxy_proxy_synapse_enabled|bool"
 
 - name: Ensure Matrix nginx-proxy configuration for matrix-dendrite exists
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/nginx/conf.d/matrix-dendrite.conf.j2"
     dest: "{{ matrix_nginx_proxy_confd_path }}/matrix-dendrite.conf"
     mode: 0644
   when: matrix_nginx_proxy_proxy_dendrite_enabled|bool
 
 - name: Ensure Matrix nginx-proxy configuration for matrix-dendrite deleted
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_nginx_proxy_confd_path }}/matrix-dendrite.conf"
     state: absent
   when: "not matrix_nginx_proxy_proxy_dendrite_enabled|bool"
 
 - name: Ensure Matrix nginx-proxy configuration for Element domain exists
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/nginx/conf.d/matrix-client-element.conf.j2"
     dest: "{{ matrix_nginx_proxy_confd_path }}/matrix-client-element.conf"
     mode: 0644
   when: matrix_nginx_proxy_proxy_element_enabled|bool
 
 - name: Ensure Matrix nginx-proxy configuration for riot domain exists
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/nginx/conf.d/matrix-riot-web.conf.j2"
     dest: "{{ matrix_nginx_proxy_confd_path }}/matrix-riot-web.conf"
     mode: 0644
   when: matrix_nginx_proxy_proxy_riot_compat_redirect_enabled|bool
 
 - name: Ensure Matrix nginx-proxy configuration for Hydrogen domain exists
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/nginx/conf.d/matrix-client-hydrogen.conf.j2"
     dest: "{{ matrix_nginx_proxy_confd_path }}/matrix-client-hydrogen.conf"
     mode: 0644
   when: matrix_nginx_proxy_proxy_hydrogen_enabled|bool
 
 - name: Ensure Matrix nginx-proxy configuration for Cinny domain exists
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/nginx/conf.d/matrix-client-cinny.conf.j2"
     dest: "{{ matrix_nginx_proxy_confd_path }}/matrix-client-cinny.conf"
     mode: 0644
   when: matrix_nginx_proxy_proxy_cinny_enabled|bool
 
 - name: Ensure Matrix nginx-proxy configuration for buscarron domain exists
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/nginx/conf.d/matrix-bot-buscarron.conf.j2"
     dest: "{{ matrix_nginx_proxy_confd_path }}/matrix-bot-buscarron.conf"
     mode: 0644
   when: matrix_nginx_proxy_proxy_buscarron_enabled|bool
 
 - name: Ensure Matrix nginx-proxy configuration for dimension domain exists
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/nginx/conf.d/matrix-dimension.conf.j2"
     dest: "{{ matrix_nginx_proxy_confd_path }}/matrix-dimension.conf"
     mode: 0644
   when: matrix_nginx_proxy_proxy_dimension_enabled|bool
 
 - name: Ensure Matrix nginx-proxy configuration for goneb domain exists
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/nginx/conf.d/matrix-bot-go-neb.conf.j2"
     dest: "{{ matrix_nginx_proxy_confd_path }}/matrix-bot-go-neb.conf"
     mode: 0644
   when: matrix_nginx_proxy_proxy_bot_go_neb_enabled|bool
 
 - name: Ensure Matrix nginx-proxy configuration for jitsi domain exists
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/nginx/conf.d/matrix-jitsi.conf.j2"
     dest: "{{ matrix_nginx_proxy_confd_path }}/matrix-jitsi.conf"
     mode: 0644
   when: matrix_nginx_proxy_proxy_jitsi_enabled|bool
 
 - name: Ensure Matrix nginx-proxy configuration for grafana domain exists
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/nginx/conf.d/matrix-grafana.conf.j2"
     dest: "{{ matrix_nginx_proxy_confd_path }}/matrix-grafana.conf"
     mode: 0644
   when: matrix_nginx_proxy_proxy_grafana_enabled|bool
 
 - name: Ensure Matrix nginx-proxy configuration for sygnal domain exists
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/nginx/conf.d/matrix-sygnal.conf.j2"
     dest: "{{ matrix_nginx_proxy_confd_path }}/matrix-sygnal.conf"
     mode: 0644
   when: matrix_nginx_proxy_proxy_sygnal_enabled|bool
 
 - name: Ensure Matrix nginx-proxy configuration for ntfy domain exists
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/nginx/conf.d/matrix-ntfy.conf.j2"
     dest: "{{ matrix_nginx_proxy_confd_path }}/matrix-ntfy.conf"
     mode: 0644
   when: matrix_nginx_proxy_proxy_ntfy_enabled|bool
 
 - name: Ensure Matrix nginx-proxy configuration for Matrix domain exists
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/nginx/conf.d/matrix-domain.conf.j2"
     dest: "{{ matrix_nginx_proxy_confd_path }}/matrix-domain.conf"
     mode: 0644
 
 - name: Ensure Matrix nginx-proxy data directory for base domain exists
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_nginx_proxy_data_path }}/matrix-domain"
     state: directory
     mode: 0750
@@ -161,7 +161,7 @@
   when: matrix_nginx_proxy_base_domain_serving_enabled|bool and matrix_nginx_proxy_base_domain_create_directory|bool
 
 - name: Ensure Matrix nginx-proxy homepage for base domain exists
-  copy:
+  ansible.builtin.copy:
     content: "{{ matrix_nginx_proxy_base_domain_homepage_template }}"
     dest: "{{ matrix_nginx_proxy_data_path }}/matrix-domain/index.html"
     mode: 0644
@@ -170,7 +170,7 @@
   when: matrix_nginx_proxy_base_domain_serving_enabled|bool and matrix_nginx_proxy_base_domain_homepage_enabled|bool and matrix_nginx_proxy_base_domain_create_directory|bool
 
 - name: Ensure Matrix nginx-proxy configuration for base domain exists
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/nginx/conf.d/matrix-base-domain.conf.j2"
     dest: "{{ matrix_nginx_proxy_confd_path }}/matrix-base-domain.conf"
     mode: 0644
@@ -192,7 +192,7 @@
   until: result is not failed
 
 - name: Ensure matrix-nginx-proxy.service installed
-  template:
+  ansible.builtin.template:
     src: "{{ role_path }}/templates/systemd/matrix-nginx-proxy.service.j2"
     dest: "{{ matrix_systemd_path }}/matrix-nginx-proxy.service"
     mode: 0644
@@ -200,7 +200,7 @@
   when: matrix_nginx_proxy_enabled|bool
 
 - name: Ensure systemd reloaded after matrix-nginx-proxy.service installation
-  service:
+  ansible.builtin.service:
     daemon_reload: true
   when: "matrix_nginx_proxy_enabled and matrix_nginx_proxy_systemd_service_result.changed"
 
@@ -216,7 +216,7 @@
   when: "not matrix_nginx_proxy_enabled|bool"
 
 - name: Ensure matrix-nginx-proxy is stopped
-  service:
+  ansible.builtin.service:
     name: matrix-nginx-proxy
     state: stopped
     enabled: false
@@ -225,113 +225,113 @@
   when: "not matrix_nginx_proxy_enabled|bool and matrix_nginx_proxy_service_stat.stat.exists"
 
 - name: Ensure matrix-nginx-proxy.service doesn't exist
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_systemd_path }}/matrix-nginx-proxy.service"
     state: absent
   when: "not matrix_nginx_proxy_enabled|bool and matrix_nginx_proxy_service_stat.stat.exists"
 
 - name: Ensure systemd reloaded after matrix-nginx-proxy.service removal
-  service:
+  ansible.builtin.service:
     daemon_reload: true
   when: "not matrix_nginx_proxy_enabled|bool and matrix_nginx_proxy_service_stat.stat.exists"
 
 - name: Ensure Matrix nginx-proxy configuration for matrix domain deleted
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_nginx_proxy_confd_path }}/matrix-domain.conf"
     state: absent
   when: "not matrix_nginx_proxy_proxy_matrix_enabled|bool"
 
 - name: Ensure Matrix nginx-proxy configuration for riot domain deleted
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_nginx_proxy_confd_path }}/matrix-riot-web.conf"
     state: absent
   when: "not matrix_nginx_proxy_proxy_riot_compat_redirect_enabled|bool"
 
 - name: Ensure Matrix nginx-proxy configuration for Hydrogen domain deleted
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_nginx_proxy_confd_path }}/matrix-client-hydrogen.conf"
     state: absent
   when: "not matrix_nginx_proxy_proxy_hydrogen_enabled|bool"
 
 - name: Ensure Matrix nginx-proxy configuration for Cinny domain deleted
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_nginx_proxy_confd_path }}/matrix-client-cinny.conf"
     state: absent
   when: "not matrix_nginx_proxy_proxy_cinny_enabled|bool"
 
 - name: Ensure Matrix nginx-proxy configuration for buscarron domain deleted
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_nginx_proxy_confd_path }}/matrix-bot-buscarron.conf"
     state: absent
   when: "not matrix_nginx_proxy_proxy_buscarron_enabled|bool"
 
 - name: Ensure Matrix nginx-proxy configuration for dimension domain deleted
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_nginx_proxy_confd_path }}/matrix-dimension.conf"
     state: absent
   when: "not matrix_nginx_proxy_proxy_dimension_enabled|bool"
 
 - name: Ensure Matrix nginx-proxy configuration for goneb domain deleted
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_nginx_proxy_confd_path }}/matrix-bot-go-neb.conf"
     state: absent
   when: "not matrix_nginx_proxy_proxy_bot_go_neb_enabled|bool"
 
 - name: Ensure Matrix nginx-proxy configuration for jitsi domain deleted
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_nginx_proxy_confd_path }}/matrix-jitsi.conf"
     state: absent
   when: "not matrix_nginx_proxy_proxy_jitsi_enabled|bool"
 
 - name: Ensure Matrix nginx-proxy configuration for grafana domain deleted
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_nginx_proxy_confd_path }}/matrix-grafana.conf"
     state: absent
   when: "not matrix_nginx_proxy_proxy_grafana_enabled|bool"
 
 - name: Ensure Matrix nginx-proxy configuration for sygnal domain deleted
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_nginx_proxy_confd_path }}/matrix-sygnal.conf"
     state: absent
   when: "not matrix_nginx_proxy_proxy_sygnal_enabled|bool"
 
 - name: Ensure Matrix nginx-proxy configuration for ntfy domain deleted
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_nginx_proxy_confd_path }}/matrix-ntfy.conf"
     state: absent
   when: "not matrix_nginx_proxy_proxy_ntfy_enabled|bool"
 
 - name: Ensure Matrix nginx-proxy homepage for base domain deleted
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_nginx_proxy_data_path }}/matrix-domain/index.html"
     state: absent
   when: "not matrix_nginx_proxy_base_domain_serving_enabled|bool"
 
 - name: Ensure Matrix nginx-proxy configuration for base domain deleted
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_nginx_proxy_confd_path }}/matrix-base-domain.conf"
     state: absent
   when: "not matrix_nginx_proxy_base_domain_serving_enabled|bool"
 
 - name: Ensure Matrix nginx-proxy configuration for main config override deleted
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_nginx_proxy_base_path }}/nginx.conf"
     state: absent
   when: "not matrix_nginx_proxy_enabled|bool"
 
 - name: Ensure Matrix nginx-proxy htpasswd is deleted (protecting /_synapse/metrics URI)
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_nginx_proxy_data_path }}/matrix-synapse-metrics-htpasswd"
     state: absent
 
 # This file is now generated by the matrix-synapse role and saved in the Synapse directory
 - name: (Cleanup) Ensure old sample prometheus.yml for external scraping is deleted
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_base_data_path }}/external_prometheus.yml.example"
     state: absent
 
 - name: Ensure Matrix nginx-proxy htpasswd is deleted (protecting /metrics/* URIs)
-  file:
+  ansible.builtin.file:
     path: "{{ matrix_nginx_proxy_data_path }}/matrix-metrics-htpasswd"
     state: absent
   when: "not matrix_nginx_proxy_proxy_matrix_metrics_enabled|bool or not matrix_nginx_proxy_proxy_matrix_metrics_basic_auth_enabled|bool"