cqrenet/matrix-docker-ansible-deploy
6
0
Fork 0
mirror of https://github.com/spantaleev/matrix-docker-ansible-deploy.git synced 2026-09-17 05:10:09 +00:00
Code Issues Wiki Activity

Don't reset Hookshot's crypto store on a run that selects no tags

Browse Source 
`tasks/main.yml` opens with a block tagged `reset-hookshot-encryption`, and
Ansible runs tagged tasks unless tags are actually selected. A run that selects
no tags therefore reaches `tasks/reset_encryption.yml`: on a host where the
service does not exist yet it fails outright, and on one where it does it stops
the bridge and resets its crypto store without being asked to.

Users of the playbook are shielded from this only because the documented way to
run it always passes `--tags=setup-all,start`.

Adding `never` makes the block reachable only when its tag is explicitly
selected, which is what `--tags=reset-hookshot-encryption` in
docs/configuring-playbook-bridge-hookshot.md already does - that keeps working
unchanged, as selecting a tag by name overrides `never`.

The Molecule scenario no longer needs its `skip-tags` workaround, which is what
makes this verifiable: the scenario runs with no tags selected, and is green
with the workaround gone.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SEH3vxYSQ5SV4N5z61eyGT
This commit is contained in:
Slavi Pantaleev
2026-08-27 18:02:53 +03:00
co-authored by Claude Opus 5
parent 705f561777
commit fe2fa6eaca
2 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
roles/custom/matrix-bridge-hookshot/molecule/default/molecule.yml
-11
View File
@@ -24,17 +24,6 @@ provisioner:
config_options:
defaults:
callback_result_format: yaml
options:
# The role's `tasks/main.yml` opens with a block tagged
# `reset-hookshot-encryption`, and Ansible runs tagged tasks unless tags are
# actually selected - so a tagless play (which is what Molecule runs) hits
# it. It stops `matrix-hookshot.service` before that service exists, which
# fails on a fresh host. Skipping the tag is what the playbook effectively
# does by always running with `--tags=setup-all,start`.
#
# `molecule-notest,notest` are Molecule's own defaults, repeated here
# because this key replaces them rather than adding to them.
skip-tags: molecule-notest,notest,reset-hookshot-encryption
inventory:
group_vars:
all: