mirror of
https://github.com/spantaleev/matrix-docker-ansible-deploy.git
synced 2026-10-22 22:34:16 +00:00
QEDeDandSlavi Pantaleev
7b44e13276
With conditional restart (install-* tags), the homeserver entry for Synapse fell through to `restart_necessary: true`, and the worker entries carried no flag at all, which systemd_service_manager also treats as "restart". Every install-all and install-service synapse therefore restarted Synapse and all of its workers, even when nothing had changed. Without workers, systemd also restarted most bridges and bots, whose units require matrix-synapse.service. Compute matrix_synapse_restart_necessary from the tasks that install what Synapse runs: homeserver.yaml, the initial config and signing key, the log config, labels and systemd service, the container image (pulled, self-built or customized), each worker's config, labels and systemd service, and the downloaded or cloned extension modules. Workers follow the same decision, as they read the same files. Synapse also mounts the appservice registration files written by other roles. Add matrix_homeserver_app_service_registration_changed in group_vars/matrix_servers, which checks the registered result of each task installing one of the files listed in matrix_homeserver_container_extra_arguments_auto, so that a changed registration still restarts Synapse and its workers. The double-puppet role did not register its result; it does now. The Synapse image pull and three extension downloads all registered their result as `result`. The downloads run first, so the pull's result overwrote theirs before the restart decision could read them; they now use role-prefixed names.