From 0148ecde8ee7989c835d8f942803dada4d812aac Mon Sep 17 00:00:00 2001 From: "Alex V." <119082209+Retengart@users.noreply.github.com> Date: Sat, 7 Feb 2026 16:29:38 +0300 Subject: [PATCH] fix: remove dead code and potential NameError in run_cmd check_call always returns 0 or raises, making retcode!=0 branches unreachable. Also remote_data was undefined with --skip-dns-check. --- cmdeploy/src/cmdeploy/cmdeploy.py | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/cmdeploy/src/cmdeploy/cmdeploy.py b/cmdeploy/src/cmdeploy/cmdeploy.py index 56d39b1f..9a7a91ae 100644 --- a/cmdeploy/src/cmdeploy/cmdeploy.py +++ b/cmdeploy/src/cmdeploy/cmdeploy.py @@ -113,24 +113,15 @@ def run_cmd(args, out): return 1 try: - retcode = out.check_call(cmd, env=env) + out.check_call(cmd, env=env) if args.website_only: - if retcode == 0: - out.green("Website deployment completed.") - else: - out.red("Website deployment failed.") - elif retcode == 0: - out.green("Deploy completed, call `cmdeploy dns` next.") - elif not remote_data["acme_account_url"]: - out.red("Deploy completed but letsencrypt not configured") - out.red("Run 'cmdeploy run' again") - retcode = 0 + out.green("Website deployment completed.") else: - out.red("Deploy failed") + out.green("Deploy completed, call `cmdeploy dns` next.") + return 0 except subprocess.CalledProcessError: out.red("Deploy failed") - retcode = 1 - return retcode + return 1 def dns_cmd_options(parser):