cqrenet/relay
3
0
Fork 0
mirror of https://github.com/chatmail/relay.git synced 2026-05-10 16:04:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove dead code and potential NameError in run_cmd

Browse Source 
check_call always returns 0 or raises, making retcode!=0 branches
unreachable. Also remote_data was undefined with --skip-dns-check.
This commit is contained in:
Alex V.
2026-02-07 16:29:38 +03:00
committed by missytake
parent 31301abb42
commit 2432d4f498
1 changed files with 5 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
cmdeploy/src/cmdeploy/cmdeploy.py
View File

@@ -119,24 +119,18 @@ def run_cmd(args, out):
return 1 return 1
try: try:
retcode = out.check_call(cmd, env=env) out.check_call(cmd, env=env)
if args.website_only: if args.website_only:
if retcode == 0: out.green("Website deployment completed.")
out.green("Website deployment completed.")
else:
out.red("Website deployment failed.")
elif retcode == 0:
out.green("Deploy completed, call `cmdeploy dns` next.")
elif not args.dns_check_disabled and strict_tls and not remote_data["acme_account_url"]: elif not args.dns_check_disabled and strict_tls and not remote_data["acme_account_url"]:
out.red("Deploy completed but letsencrypt not configured") out.red("Deploy completed but letsencrypt not configured")
out.red("Run 'cmdeploy run' again") out.red("Run 'cmdeploy run' again")
retcode = 0
else: else:
out.red("Deploy failed") out.green("Deploy completed, call `cmdeploy dns` next.")
return 0
except subprocess.CalledProcessError: except subprocess.CalledProcessError:
out.red("Deploy failed") out.red("Deploy failed")
retcode = 1 return 1
return retcode
def dns_cmd_options(parser): def dns_cmd_options(parser):