From 354418c87799211e5ad02b99c67d2caa11aea515 Mon Sep 17 00:00:00 2001
From: cliffmccarthy <16453869+cliffmccarthy@users.noreply.github.com>
Date: Tue, 11 Nov 2025 14:54:44 -0600
Subject: [PATCH] refactor: Pass all constructor arguments by position

- The constructor arguments do not have default values; they are all
  required.  Revised deploy_chatmail() to pass them by position rather
  than name, so that the caller is not coupled to the names of the
  arguments inside the method definition.
---
 cmdeploy/src/cmdeploy/__init__.py | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/cmdeploy/src/cmdeploy/__init__.py b/cmdeploy/src/cmdeploy/__init__.py
index 7fd8bbf4..7e8fe14c 100644
--- a/cmdeploy/src/cmdeploy/__init__.py
+++ b/cmdeploy/src/cmdeploy/__init__.py
@@ -1104,28 +1104,28 @@ def deploy_chatmail(config_path: Path, disable_mail: bool) -> None:
     tls_domains = [mail_domain, f"mta-sts.{mail_domain}", f"www.{mail_domain}"]
 
     all_deployers = [
-        ChatmailDeployer(mail_domain=mail_domain),
+        ChatmailDeployer(mail_domain),
         JournaldDeployer(),
         UnboundDeployer(),
-        TurnDeployer(mail_domain=mail_domain),
-        IrohDeployer(enable_iroh_relay=config.enable_iroh_relay),
-        AcmetoolDeployer(email=config.acme_email, domains=tls_domains),
+        TurnDeployer(mail_domain),
+        IrohDeployer(config.enable_iroh_relay),
+        AcmetoolDeployer(config.acme_email, tls_domains),
 
-        WebsiteDeployer(config=config),
-        ChatmailVenvDeployer(config=config),
+        WebsiteDeployer(config),
+        ChatmailVenvDeployer(config),
         MtastsDeployer(),
-        OpendkimDeployer(mail_domain=mail_domain),
+        OpendkimDeployer(mail_domain),
 
         # Dovecot should be started before Postfix
         # because it creates authentication socket
         # required by Postfix.
-        DovecotDeployer(config=config, disable_mail=disable_mail),
-        PostfixDeployer(config=config, disable_mail=disable_mail),
+        DovecotDeployer(config, disable_mail),
+        PostfixDeployer(config, disable_mail),
         FcgiwrapDeployer(),
-        NginxDeployer(config=config),
+        NginxDeployer(config),
         RspamdDeployer(),
-        EchobotDeployer(mail_domain=mail_domain),
-        MtailDeployer(mtail_address=config.mtail_address),
+        EchobotDeployer(mail_domain),
+        MtailDeployer(config.mtail_address),
         GithashDeployer(),
     ]