diff --git a/docs/threepids/notification/sendgrid-handler.md b/docs/threepids/notification/sendgrid-handler.md index 5719d18..db8b26d 100644 --- a/docs/threepids/notification/sendgrid-handler.md +++ b/docs/threepids/notification/sendgrid-handler.md @@ -26,16 +26,10 @@ notification: html: session: validation: - local: - subject: - body: - text: - html: - remote: - subject: - body: - text: - html: + subject: + body: + text: + html: unbind: fraudulent: subject: diff --git a/docs/threepids/notification/template-generator.md b/docs/threepids/notification/template-generator.md index 9a10af7..53157b4 100644 --- a/docs/threepids/notification/template-generator.md +++ b/docs/threepids/notification/template-generator.md @@ -18,9 +18,7 @@ threepid: template: invite: '/path/to/invite-template.eml' session: - validation: - local: '/path/to/validate-local-template.eml' - remote: '/path/to/validate-remote-template.eml' + validation: '/path/to/validate-template.eml' unbind: frandulent: '/path/to/unbind-fraudulent-template.eml' generic: diff --git a/src/main/java/io/kamax/mxisd/config/threepid/connector/EmailSendGridConfig.java b/src/main/java/io/kamax/mxisd/config/threepid/connector/EmailSendGridConfig.java index 956fdf7..c9aeca3 100644 --- a/src/main/java/io/kamax/mxisd/config/threepid/connector/EmailSendGridConfig.java +++ b/src/main/java/io/kamax/mxisd/config/threepid/connector/EmailSendGridConfig.java @@ -115,28 +115,6 @@ public class EmailSendGridConfig { public static class Templates { - public static class TemplateSessionValidation { - - private EmailTemplate local = new EmailTemplate(); - private EmailTemplate remote = new EmailTemplate(); - - public EmailTemplate getLocal() { - return local; - } - - public void setLocal(EmailTemplate local) { - this.local = local; - } - - public EmailTemplate getRemote() { - return remote; - } - - public void setRemote(EmailTemplate remote) { - this.remote = remote; - } - } - public static class TemplateSessionUnbind { private EmailTemplate fraudulent = new EmailTemplate(); @@ -153,14 +131,14 @@ public class EmailSendGridConfig { public static class TemplateSession { - private TemplateSessionValidation validation = new TemplateSessionValidation(); + private EmailTemplate validation = new EmailTemplate(); private TemplateSessionUnbind unbind = new TemplateSessionUnbind(); - public TemplateSessionValidation getValidation() { + public EmailTemplate getValidation() { return validation; } - public void setValidation(TemplateSessionValidation validation) { + public void setValidation(EmailTemplate validation) { this.validation = validation; } diff --git a/src/main/java/io/kamax/mxisd/config/threepid/medium/EmailTemplateConfig.java b/src/main/java/io/kamax/mxisd/config/threepid/medium/EmailTemplateConfig.java index 712a52e..3e9ad41 100644 --- a/src/main/java/io/kamax/mxisd/config/threepid/medium/EmailTemplateConfig.java +++ b/src/main/java/io/kamax/mxisd/config/threepid/medium/EmailTemplateConfig.java @@ -30,17 +30,17 @@ public class EmailTemplateConfig extends GenericTemplateConfig { public EmailTemplateConfig() { setInvite("classpath:/threepids/email/invite-template.eml"); getGeneric().put("matrixId", "classpath:/threepids/email/mxid-template.eml"); - getSession().getValidation().setLocal("classpath:/threepids/email/validate-local-template.eml"); - getSession().getValidation().setRemote("classpath:/threepids/email/validate-remote-template.eml"); + getSession().setValidation("classpath:/threepids/email/validate-template.eml"); getSession().getUnbind().setFraudulent("classpath:/threepids/email/unbind-fraudulent.eml"); } public EmailTemplateConfig build() { log.info("--- E-mail Generator templates config ---"); log.info("Invite: {}", getName(getInvite())); - log.info("Session validation:"); - log.info("\tLocal: {}", getName(getSession().getValidation().getLocal())); - log.info("\tRemote: {}", getName(getSession().getValidation().getRemote())); + log.info("Session:"); + log.info("\tValidation: {}", getSession().getValidation()); + log.info("\tUnbind:"); + log.info("\t\tFraudulent: {}", getSession().getUnbind().getFraudulent()); return this; } diff --git a/src/main/java/io/kamax/mxisd/config/threepid/medium/GenericTemplateConfig.java b/src/main/java/io/kamax/mxisd/config/threepid/medium/GenericTemplateConfig.java index 434829e..c6c9beb 100644 --- a/src/main/java/io/kamax/mxisd/config/threepid/medium/GenericTemplateConfig.java +++ b/src/main/java/io/kamax/mxisd/config/threepid/medium/GenericTemplateConfig.java @@ -39,29 +39,6 @@ public class GenericTemplateConfig { public static class Session { - public static class SessionValidation { - - private String local; - private String remote; - - public String getLocal() { - return local; - } - - public void setLocal(String local) { - this.local = local; - } - - public String getRemote() { - return remote; - } - - public void setRemote(String remote) { - this.remote = remote; - } - - } - public static class SessionUnbind { private String fraudulent; @@ -76,14 +53,14 @@ public class GenericTemplateConfig { } - private SessionValidation validation = new SessionValidation(); + private String validation; private SessionUnbind unbind = new SessionUnbind(); - public SessionValidation getValidation() { + public String getValidation() { return validation; } - public void setValidation(SessionValidation validation) { + public void setValidation(String validation) { this.validation = validation; } diff --git a/src/main/java/io/kamax/mxisd/config/threepid/medium/PhoneSmsTemplateConfig.java b/src/main/java/io/kamax/mxisd/config/threepid/medium/PhoneSmsTemplateConfig.java index 909d6fa..a14c200 100644 --- a/src/main/java/io/kamax/mxisd/config/threepid/medium/PhoneSmsTemplateConfig.java +++ b/src/main/java/io/kamax/mxisd/config/threepid/medium/PhoneSmsTemplateConfig.java @@ -29,18 +29,17 @@ public class PhoneSmsTemplateConfig extends GenericTemplateConfig { public PhoneSmsTemplateConfig() { setInvite("classpath:/threepids/sms/invite-template.txt"); - getGeneric().put("matrixId", "classpath:/threepids/email/mxid-template.eml"); - getSession().getValidation().setLocal("classpath:/threepids/sms/validate-local-template.txt"); - getSession().getValidation().setRemote("classpath:/threepids/sms/validate-remote-template.txt"); + getSession().setValidation("classpath:/threepids/sms/validate-template.txt"); getSession().getUnbind().setFraudulent("classpath:/threepids/sms/unbind-fraudulent.txt"); } public PhoneSmsTemplateConfig build() { log.info("--- SMS Generator templates config ---"); log.info("Invite: {}", getName(getInvite())); - log.info("Session validation:"); - log.info("\tLocal: {}", getName(getSession().getValidation().getLocal())); - log.info("\tRemote: {}", getName(getSession().getValidation().getRemote())); + log.info("Session:"); + log.info("\tValidation: {}", getSession().getValidation()); + log.info("\tUnbind:"); + log.info("\t\tFraudulent: {}", getSession().getUnbind().getFraudulent()); return this; } diff --git a/src/main/java/io/kamax/mxisd/notification/NotificationHandler.java b/src/main/java/io/kamax/mxisd/notification/NotificationHandler.java index 1b7fbd8..07056e5 100644 --- a/src/main/java/io/kamax/mxisd/notification/NotificationHandler.java +++ b/src/main/java/io/kamax/mxisd/notification/NotificationHandler.java @@ -37,8 +37,6 @@ public interface NotificationHandler { void sendForValidation(IThreePidSession session); - void sendForRemoteValidation(IThreePidSession session); - void sendForFraudulentUnbind(ThreePid tpid); } diff --git a/src/main/java/io/kamax/mxisd/notification/NotificationManager.java b/src/main/java/io/kamax/mxisd/notification/NotificationManager.java index 5091f86..22a8e57 100644 --- a/src/main/java/io/kamax/mxisd/notification/NotificationManager.java +++ b/src/main/java/io/kamax/mxisd/notification/NotificationManager.java @@ -78,10 +78,6 @@ public class NotificationManager { ensureMedium(session.getThreePid().getMedium()).sendForValidation(session); } - public void sendForRemoteValidation(IThreePidSession session) { - ensureMedium(session.getThreePid().getMedium()).sendForRemoteValidation(session); - } - public void sendForFraudulentUnbind(ThreePid tpid) throws NotImplementedException { ensureMedium(tpid.getMedium()).sendForFraudulentUnbind(tpid); } diff --git a/src/main/java/io/kamax/mxisd/threepid/generator/GenericTemplateNotificationGenerator.java b/src/main/java/io/kamax/mxisd/threepid/generator/GenericTemplateNotificationGenerator.java index f6abde1..ad35ddd 100644 --- a/src/main/java/io/kamax/mxisd/threepid/generator/GenericTemplateNotificationGenerator.java +++ b/src/main/java/io/kamax/mxisd/threepid/generator/GenericTemplateNotificationGenerator.java @@ -74,13 +74,7 @@ public abstract class GenericTemplateNotificationGenerator extends PlaceholderNo @Override public String getForValidation(IThreePidSession session) { log.info("Generating notification content for 3PID Session validation"); - return populateForValidation(session, getTemplateContent(cfg.getSession().getValidation().getLocal())); - } - - @Override - public String getForRemoteValidation(IThreePidSession session) { - log.info("Generating notification content for remote-only 3PID session"); - return populateForRemoteValidation(session, getTemplateContent(cfg.getSession().getValidation().getRemote())); + return populateForValidation(session, getTemplateContent(cfg.getSession().getValidation())); } @Override diff --git a/src/main/java/io/kamax/mxisd/threepid/generator/NotificationGenerator.java b/src/main/java/io/kamax/mxisd/threepid/generator/NotificationGenerator.java index 3e6ade1..eb5f49d 100644 --- a/src/main/java/io/kamax/mxisd/threepid/generator/NotificationGenerator.java +++ b/src/main/java/io/kamax/mxisd/threepid/generator/NotificationGenerator.java @@ -37,8 +37,6 @@ public interface NotificationGenerator { String getForValidation(IThreePidSession session); - String getForRemoteValidation(IThreePidSession session); - String getForFraudulentUnbind(ThreePid tpid); } diff --git a/src/main/java/io/kamax/mxisd/threepid/notification/GenericNotificationHandler.java b/src/main/java/io/kamax/mxisd/threepid/notification/GenericNotificationHandler.java index 3b4f72a..b6992a0 100644 --- a/src/main/java/io/kamax/mxisd/threepid/notification/GenericNotificationHandler.java +++ b/src/main/java/io/kamax/mxisd/threepid/notification/GenericNotificationHandler.java @@ -72,11 +72,6 @@ public abstract class GenericNotificationHandler