From e7c4c12a98805b078a328e10b07e5b4720659d1c Mon Sep 17 00:00:00 2001 From: Xavier Johnson Date: Fri, 18 Dec 2020 22:52:45 -0500 Subject: [PATCH] #76 Set a message for error responses Without one, clients might treat errors as generic failures instead of handling them in a manner appropriate for their error code --- .../java/io/kamax/mxisd/exception/InvalidParamException.java | 1 + .../java/io/kamax/mxisd/exception/InvalidPepperException.java | 1 + .../io/kamax/mxisd/http/undertow/handler/BasicHttpHandler.java | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/java/io/kamax/mxisd/exception/InvalidParamException.java b/src/main/java/io/kamax/mxisd/exception/InvalidParamException.java index 571329f..05fca83 100644 --- a/src/main/java/io/kamax/mxisd/exception/InvalidParamException.java +++ b/src/main/java/io/kamax/mxisd/exception/InvalidParamException.java @@ -23,5 +23,6 @@ package io.kamax.mxisd.exception; public class InvalidParamException extends RuntimeException { public InvalidParamException() { + super("The chosen hash algorithm is invalid or disallowed"); } } diff --git a/src/main/java/io/kamax/mxisd/exception/InvalidPepperException.java b/src/main/java/io/kamax/mxisd/exception/InvalidPepperException.java index 59bc1ff..34078b4 100644 --- a/src/main/java/io/kamax/mxisd/exception/InvalidPepperException.java +++ b/src/main/java/io/kamax/mxisd/exception/InvalidPepperException.java @@ -23,5 +23,6 @@ package io.kamax.mxisd.exception; public class InvalidPepperException extends RuntimeException { public InvalidPepperException() { + super("The provided pepper is invalid or expired"); } } diff --git a/src/main/java/io/kamax/mxisd/http/undertow/handler/BasicHttpHandler.java b/src/main/java/io/kamax/mxisd/http/undertow/handler/BasicHttpHandler.java index 46e6c31..59df3b7 100644 --- a/src/main/java/io/kamax/mxisd/http/undertow/handler/BasicHttpHandler.java +++ b/src/main/java/io/kamax/mxisd/http/undertow/handler/BasicHttpHandler.java @@ -189,7 +189,7 @@ public abstract class BasicHttpHandler implements HttpHandler { } protected void respond(HttpServerExchange ex, int status, String errCode, String error) { - respond(ex, status, buildErrorBody(ex, errCode, error)); + respond(ex, status, buildErrorBody(ex, errCode, error != null ? error : "An error has occurred")); } protected void handleException(HttpServerExchange exchange, HttpMatrixException ex) {