From 8c8445c9d9b21c28ae3194acb4d9e92301a9b01d Mon Sep 17 00:00:00 2001 From: DrIOS <58635327+DrIOSX@users.noreply.github.com> Date: Fri, 28 Jun 2024 16:09:13 -0500 Subject: [PATCH 1/3] fix: Export Table Changes Reverted --- helpers/Build-Help.ps1 | 2 +- source/Public/Export-M365SecurityAuditTable.ps1 | 9 +++------ 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/helpers/Build-Help.ps1 b/helpers/Build-Help.ps1 index ab6e3fe..0082585 100644 --- a/helpers/Build-Help.ps1 +++ b/helpers/Build-Help.ps1 @@ -4,7 +4,7 @@ Import-Module .\output\module\M365FoundationsCISReport\*\*.psd1 <# - $ver = "v0.1.15" + $ver = "v0.1.16" git checkout main git pull origin main git tag -a $ver -m "Release version $ver refactor Update" diff --git a/source/Public/Export-M365SecurityAuditTable.ps1 b/source/Public/Export-M365SecurityAuditTable.ps1 index fbe507b..fc16d64 100644 --- a/source/Public/Export-M365SecurityAuditTable.ps1 +++ b/source/Public/Export-M365SecurityAuditTable.ps1 @@ -201,12 +201,9 @@ function Export-M365SecurityAuditTable { if ($ExportOriginalTests) { # Define the test numbers to check $TestNumbersToCheck = "1.1.1", "1.3.1", "6.1.2", "6.1.3", "7.3.4" - if ($exportedTests.Count -gt 0) { - $updatedAuditResults = Get-ExceededLengthResultDetail -AuditResults $AuditResults -TestNumbersToCheck $TestNumbersToCheck -ExportedTests $exportedTests -DetailsLengthLimit 30000 -PreviewLineCount 25 - } - else { - $updatedAuditResults = $auditResults - } + + # Check for large details and update the AuditResults array + $updatedAuditResults = Get-ExceededLengthResultDetail -AuditResults $AuditResults -TestNumbersToCheck $TestNumbersToCheck -ExportedTests $exportedTests -DetailsLengthLimit 30000 -PreviewLineCount 25 $originalFileName = "$ExportPath\$timestamp`_M365FoundationsAudit.csv" if ($ExportToExcel) { $xlsxPath = [System.IO.Path]::ChangeExtension($originalFileName, '.xlsx') From 5909f8d3b486fbad74b3740e46ab9b7c43ab5aea Mon Sep 17 00:00:00 2001 From: DrIOS <58635327+DrIOSX@users.noreply.github.com> Date: Fri, 28 Jun 2024 17:04:10 -0500 Subject: [PATCH 2/3] fix: Get-ExceededLengthResultDetail parameter validation --- source/Private/Get-ExceededLengthResultDetail.ps1 | 2 +- source/Public/Export-M365SecurityAuditTable.ps1 | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/source/Private/Get-ExceededLengthResultDetail.ps1 b/source/Private/Get-ExceededLengthResultDetail.ps1 index ea2bee5..a9d7c46 100644 --- a/source/Private/Get-ExceededLengthResultDetail.ps1 +++ b/source/Private/Get-ExceededLengthResultDetail.ps1 @@ -9,7 +9,7 @@ function Get-ExceededLengthResultDetail { [Parameter(Mandatory = $true, ParameterSetName = 'ReturnExceedingTests')] [string[]]$TestNumbersToCheck, - [Parameter(Mandatory = $true, ParameterSetName = 'UpdateArray')] + [Parameter(Mandatory = $false, ParameterSetName = 'UpdateArray')] [string[]]$ExportedTests, [Parameter(Mandatory = $true, ParameterSetName = 'ReturnExceedingTests')] diff --git a/source/Public/Export-M365SecurityAuditTable.ps1 b/source/Public/Export-M365SecurityAuditTable.ps1 index fc16d64..bb3d3b3 100644 --- a/source/Public/Export-M365SecurityAuditTable.ps1 +++ b/source/Public/Export-M365SecurityAuditTable.ps1 @@ -61,8 +61,8 @@ function Export-M365SecurityAuditTable { [ValidateSet("1.1.1", "1.3.1", "6.1.2", "6.1.3", "7.3.4")] [string]$OutputTestNumber, - [Parameter(Mandatory = $true, Position = 0, ParameterSetName = "ExportAllResultsFromAuditResults")] - [Parameter(Mandatory = $true, Position = 0, ParameterSetName = "ExportAllResultsFromCsv")] + [Parameter(Mandatory = $false, Position = 0, ParameterSetName = "ExportAllResultsFromAuditResults")] + [Parameter(Mandatory = $false, Position = 0, ParameterSetName = "ExportAllResultsFromCsv")] [switch]$ExportAllTests, [Parameter(Mandatory = $true, ParameterSetName = "ExportAllResultsFromAuditResults")] From 1fbf321449aa0dff4b2490a7e39a7c0adb706a9c Mon Sep 17 00:00:00 2001 From: DrIOS <58635327+DrIOSX@users.noreply.github.com> Date: Fri, 28 Jun 2024 17:09:28 -0500 Subject: [PATCH 3/3] docs: Update CHANGELOG --- CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 87f5b60..f600e29 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,12 @@ The format is based on and uses the types of changes according to [Keep a Change ## [Unreleased] +### Fixed + +- Fixed `Get-ExceededLengthResultDetail` function paramter validation for Exported Tests to allow for Null. + +## [0.1.16] - 2024-06-26 + ### Added - Added `Grant-M365SecurityAuditConsent` function to consent to the Microsoft Graph Powershell API for a user.