fix: script analyzer reccomendations.

This commit is contained in:
DrIOS
2024-06-08 13:26:13 -05:00
parent 5871294210
commit 4ab5affc9f
10 changed files with 13 additions and 10 deletions

View File

@@ -1,4 +1,4 @@
function Format-MissingActions {
function Format-MissingAction {
param ([array]$missingActions)
$actionGroups = @{

View File

@@ -1,5 +1,6 @@
function Get-RequiredModule {
[CmdletBinding(DefaultParameterSetName = 'AuditFunction')]
[OutputType([PSCustomObject])]
param (
[Parameter(Mandatory = $true, ParameterSetName = 'AuditFunction')]
[switch]$AuditFunction,

View File

@@ -25,7 +25,7 @@ function Update-CISExcelWorksheet {
# Update the worksheet with the provided data
Update-WorksheetCells -Worksheet $worksheet -Data $Data -StartingRowIndex $StartingRowIndex
Update-WorksheetCell -Worksheet $worksheet -Data $Data -StartingRowIndex $StartingRowIndex
# Save and close the Excel package
Close-ExcelPackage $excelPackage

View File

@@ -1,4 +1,4 @@
function Update-WorksheetCells {
function Update-WorksheetCell {
param (
$Worksheet,
$Data,

View File

@@ -25,6 +25,8 @@
https://criticalsolutionsnetwork.github.io/M365FoundationsCISReport/#Get-AdminRoleUserLicense
#>
function Get-AdminRoleUserLicense {
# Set output type to System.Collections.ArrayList
[OutputType([System.Collections.ArrayList])]
[CmdletBinding()]
param (
[Parameter(Mandatory = $false)]

View File

@@ -49,7 +49,7 @@ function Test-MailboxAuditingE3 {
}
if ($missingActions.Count -gt 0) {
$formattedActions = Format-MissingActions -missingActions $missingActions
$formattedActions = Format-MissingAction -missingActions $missingActions
$allFailures += "$userUPN|True|$($formattedActions.Admin)|$($formattedActions.Delegate)|$($formattedActions.Owner)"
}
}

View File

@@ -49,7 +49,7 @@ function Test-MailboxAuditingE5 {
}
if ($missingActions.Count -gt 0) {
$formattedActions = Format-MissingActions -missingActions $missingActions
$formattedActions = Format-MissingAction -missingActions $missingActions
$allFailures += "$userUPN|True|$($formattedActions.Admin)|$($formattedActions.Delegate)|$($formattedActions.Owner)"
}
}