From 75faf04ea6e008b34f4745ed0ea349bae8f000cf Mon Sep 17 00:00:00 2001
From: DrIOS <58635327+DrIOSX@users.noreply.github.com>
Date: Tue, 28 May 2024 13:27:15 -0500
Subject: [PATCH] fix: 7.2.3 aligned with test-template

---
 source/tests/Test-RestrictExternalSharing.ps1 | 38 ++++++++++++-------
 1 file changed, 25 insertions(+), 13 deletions(-)

diff --git a/source/tests/Test-RestrictExternalSharing.ps1 b/source/tests/Test-RestrictExternalSharing.ps1
index 7d7a47c..2034767 100644
--- a/source/tests/Test-RestrictExternalSharing.ps1
+++ b/source/tests/Test-RestrictExternalSharing.ps1
@@ -1,37 +1,49 @@
 function Test-RestrictExternalSharing {
     [CmdletBinding()]
     param (
+        # Aligned
         # Define your parameters here
     )
 
     begin {
-        # Initialization code
-
-        $auditResult = [CISAuditResult]::new()
+        # Dot source the class script if necessary
+        #. .\source\Classes\CISAuditResult.ps1
+        # Initialization code, if needed
     }
 
     process {
         # 7.2.3 (L1) Ensure external content sharing is restricted
+
+        # Retrieve the SharingCapability setting for the SharePoint tenant
         $SPOTenantSharingCapability = Get-SPOTenant | Select-Object SharingCapability
         $isRestricted = $SPOTenantSharingCapability.SharingCapability -in @('ExternalUserSharingOnly', 'ExistingExternalUserSharingOnly', 'Disabled')
 
-        # Populate the auditResult object with the required properties
+        # Prepare failure reasons and details based on compliance
+        $failureReasons = if (-not $isRestricted) {
+            "External content sharing is not adequately restricted. Current setting: $($SPOTenantSharingCapability.SharingCapability)"
+        }
+        else {
+            "N/A"
+        }
+
+        $details = "SharingCapability: $($SPOTenantSharingCapability.SharingCapability)"
+
+        # Create and populate the CISAuditResult object
+        $auditResult = [CISAuditResult]::new()
+        $auditResult.Status = if ($isRestricted) { "Pass" } else { "Fail" }
+        $auditResult.ELevel = "E3"
+        $auditResult.ProfileLevel = "L1"
+        $auditResult.Rec = "7.2.3"
+        $auditResult.RecDescription = "Ensure external content sharing is restricted"
         $auditResult.CISControlVer = "v8"
         $auditResult.CISControl = "3.3"
         $auditResult.CISDescription = "Configure Data Access Control Lists"
-
-        $auditResult.Rec = "7.2.3"
-        $auditResult.ELevel = "E3"
-        $auditResult.ProfileLevel = "L1"
         $auditResult.IG1 = $true
         $auditResult.IG2 = $true
         $auditResult.IG3 = $true
-        $auditResult.RecDescription = "Ensure external content sharing is restricted"
-
         $auditResult.Result = $isRestricted
-        $auditResult.Details = "SharingCapability: $($SPOTenantSharingCapability.SharingCapability)"
-        $auditResult.FailureReason = if (-not $isRestricted) { "External content sharing is not adequately restricted. Current setting: $($SPOTenantSharingCapability.SharingCapability)" } else { "N/A" }
-        $auditResult.Status = if ($isRestricted) { "Pass" } else { "Fail" }
+        $auditResult.Details = $details
+        $auditResult.FailureReason = $failureReasons
     }
 
     end {