vibecoding/M365FoundationsCISReport
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: 1.1.4 aligned with test-template

Browse Source
This commit is contained in:
DrIOS
2024-05-28 10:39:54 -05:00
parent dc88df6eef
commit b8690ddb44
1 changed files with 33 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
source/tests/Test-GuestUsersBiweeklyReview.ps1
View File

@@ -1,22 +1,42 @@
function Test-GuestUsersBiweeklyReview { function Test-GuestUsersBiweeklyReview {
[CmdletBinding()] [CmdletBinding()]
param () param (
# Aligned
# Define your parameters here if needed
)
begin { begin {
#. .\source\Classes\CISAuditResult.ps1 # Dot source the class script if necessary
$auditResults = @() . .\source\Classes\CISAuditResult.ps1
# Initialization code, if needed
} }
process { process {
# 1.1.4 (L1) Ensure Guest Users are reviewed at least biweekly # 1.1.4 (L1) Ensure Guest Users are reviewed at least biweekly
# The function will fail if guest users are found since they should be reviewed manually biweekly.
try { try {
# Connect to Microsoft Graph - placeholder for connection command # Retrieve guest users from Microsoft Graph
# Connect-MgGraph -Scopes "User.Read.All" # Connect-MgGraph -Scopes "User.Read.All"
$guestUsers = Get-MgUser -All -Filter "UserType eq 'Guest'" $guestUsers = Get-MgUser -All -Filter "UserType eq 'Guest'"
# Create an instance of CISAuditResult and populate it # Prepare failure reasons and details based on compliance
$failureReasons = if ($guestUsers) {
"Guest users present: $($guestUsers.Count)"
}
else {
"N/A"
}
$details = if ($guestUsers) {
$auditCommand = "Get-MgUser -All -Property UserType,UserPrincipalName | Where {`$_.UserType -ne 'Member'} | Format-Table UserPrincipalName, UserType"
"Manual review required. To list guest users, run: `"$auditCommand`"."
}
else {
"No guest users found."
}
# Create and populate the CISAuditResult object
$auditResult = [CISAuditResult]::new() $auditResult = [CISAuditResult]::new()
$auditResult.CISControl = "5.1, 5.3" $auditResult.CISControl = "5.1, 5.3"
$auditResult.CISDescription = "Establish and Maintain an Inventory of Accounts, Disable Dormant Accounts" $auditResult.CISDescription = "Establish and Maintain an Inventory of Accounts, Disable Dormant Accounts"
@@ -28,34 +48,22 @@ function Test-GuestUsersBiweeklyReview {
$auditResult.IG2 = $true $auditResult.IG2 = $true
$auditResult.IG3 = $true $auditResult.IG3 = $true
$auditResult.CISControlVer = 'v8' $auditResult.CISControlVer = 'v8'
$auditResult.Result = -not $guestUsers
if ($guestUsers) { $auditResult.Details = $details
$auditCommand = "Get-MgUser -All -Property UserType,UserPrincipalName | Where {`$_.UserType -ne 'Member'} | Format-Table UserPrincipalName, UserType" $auditResult.FailureReason = $failureReasons
$auditResult.Status = "Fail" $auditResult.Status = if ($guestUsers) { "Fail" } else { "Pass" }
$auditResult.Result = $false
$auditResult.Details = "Manual review required. To list guest users, run: `"$auditCommand`"."
$auditResult.FailureReason = "Guest users present: $($guestUsers.Count)"
} else {
$auditResult.Status = "Pass"
$auditResult.Result = $true
$auditResult.Details = "No guest users found."
$auditResult.FailureReason = "N/A"
}
} }
catch { catch {
$auditResult = [CISAuditResult]::new()
$auditResult.Status = "Error" $auditResult.Status = "Error"
$auditResult.Result = $false $auditResult.Result = $false
$auditResult.Details = "Error while attempting to check guest users. Error message: $($_.Exception.Message)" $auditResult.Details = "Error while attempting to check guest users. Error message: $($_.Exception.Message)"
$auditResult.FailureReason = "An error occurred during the audit check." $auditResult.FailureReason = "An error occurred during the audit check."
} }
$auditResults += $auditResult
} }
end { end {
# Return auditResults # Return the audit result
return $auditResults return $auditResult
} }
} }