vibecoding/M365FoundationsCISReport
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: return when higest policy passes.

Browse Source
This commit is contained in:
DrIOS
2024-12-30 13:52:34 -06:00
parent a0b524104d
commit e1ef81a249
3 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
source/Private/Get-ScopeOverlap.ps1
View File

@@ -3,7 +3,6 @@ function Get-ScopeOverlap {
param (
[Parameter(Mandatory = $true)]
[PSCustomObject]$Policy,
[Parameter(Mandatory = $true)]
[PSCustomObject[]]$OtherPolicies
)

10
source/tests/Test-AntiPhishingPolicy4.ps1
View File

@@ -31,10 +31,8 @@ function Test-AntiPhishingPolicy4 {
if ($isCompliant) {
$strictStandardCompliant = $true
$compliantPolicies += $policy.Name
# If Strict is compliant, stop evaluating further
if ($policy.Name -eq 'Strict Preset Security Policy') {
break
}
Write-Verbose "Compliant policy found: $($policy.Name). Ending evaluation."
return Initialize-CISAuditResult -Rec $RecNum -Result $true -Status 'Pass' -Details "Compliant Policies: $($policy.Name)" -FailureReason 'None'
} else {
$nonCompliantPolicies += $policy.Name
}
@@ -57,6 +55,8 @@ function Test-AntiPhishingPolicy4 {
$isCompliant = Get-PhishPolicyCompliance -policy $policy
if ($isCompliant) {
$compliantPolicies += $policy.Name
Write-Verbose "Compliant custom policy found: $($policy.Name). Ending evaluation."
return Initialize-CISAuditResult -Rec $RecNum -Result $true -Status 'Pass' -Details "Compliant Policies: $($policy.Name)" -FailureReason 'None'
} else {
$nonCompliantPolicies += $policy.Name
}
@@ -78,6 +78,8 @@ function Test-AntiPhishingPolicy4 {
$isCompliant = Get-PhishPolicyCompliance -policy $defaultPolicy
if ($isCompliant) {
$compliantPolicies += $defaultPolicy.Name
Write-Verbose "Compliant default policy found: $($defaultPolicy.Name)."
return Initialize-CISAuditResult -Rec $RecNum -Result $true -Status 'Pass' -Details "Compliant Policies: $($defaultPolicy.Name)" -FailureReason 'None'
} else {
$nonCompliantPolicies += $defaultPolicy.Name
}